Add stack vector (pre-0.12.x) #573
Merged
+58
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: 3640c0e | Previous: 1e93800 | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
2025599190 ns/iter (± 9034278) |
2051836000 ns/iter (± 9414636) |
0.99 |
rule-match-first-request/brave-list |
1102226 ns/iter (± 17803) |
1112038 ns/iter (± 6293) |
0.99 |
blocker_new/brave-list |
133818462 ns/iter (± 826718) |
143433250 ns/iter (± 539931) |
0.93 |
blocker_new/brave-list-deserialize |
23185497 ns/iter (± 60312) |
23670075 ns/iter (± 229117) |
0.98 |
memory-usage/brave-list-initial |
10213344 ns/iter (± 3) |
10213344 ns/iter (± 3) |
1 |
memory-usage/brave-list-initial/max |
60612235 ns/iter (± 3) |
60612235 ns/iter (± 3) |
1 |
memory-usage/brave-list-initial/alloc-count |
996170 ns/iter (± 3) |
1231711 ns/iter (± 3) |
0.81 |
memory-usage/brave-list-1000-requests |
2692712 ns/iter (± 3) |
2692712 ns/iter (± 3) |
1 |
memory-usage/brave-list-1000-requests/alloc-count |
69464 ns/iter (± 3) |
71607 ns/iter (± 3) |
0.97 |
url_cosmetic_resources/brave-list |
199183 ns/iter (± 3033) |
191829 ns/iter (± 505) |
1.04 |
cosmetic-class-id-match/brave-list |
3428523 ns/iter (± 968048) |
3415862 ns/iter (± 942750) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
antonok-edm
approved these changes
Nov 20, 2025
antonok-edm
pushed a commit
that referenced
this pull request
Nov 24, 2025
The PR reduces the amount of allocations by using arrayvec crate that allocates memory on a stack instead of a heap. * the number of allocations is reduced (-19%, memory-usage/brave-list-initial/alloc-count); * building time is improved (about -10%, memory-usage/brave-list-initial); * the token limit is increased up to 256; * the tests expectations were updated (one case hit the old token limit).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see PR to master: #553